toggleFavorite's ALL-list success branch updated favoriteAction to
Starred but never touched starsCount, so a row kept showing its
pre-star count even after the server had actually accepted it. Now
increments starsCount by 1 in the same update. Also guards against a
repeat tap on an already-Starred row (the ALL list can't tell a
repo's already-starred state on load, so the star stays tappable)
double-incrementing the displayed count.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Two live-confirmed 403 responses (not source reading, which had already
given one wrong answer) showed /user/starred/{owner}/{repo} requires
BOTH scopes at once: requesting write:repository alone got
required=[write:user]; requesting write:user alone then got
required=[write:repository]. Both are now requested.
Added debug-build-only HTTP status/body logging (HttpTransport
.requireSuccess) and toggleFavorite failure logging, which is how this
was actually diagnosed -- ground truth from the server beats re-reading
Go route source through a summarizing tool. Required testOptions {
unitTests { isReturnDefaultValues = true } } in build.gradle.kts so
those Log calls don't throw inside plain JVM unit tests.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Traced the live 'denied:server_error' login failure to Gitea 1.23.5's
own GrantApplicationOAuth: it refuses to silently widen an existing
OAuth2 grant's scope (grant.Scope != form.Scope -> ErrorCodeServerError,
'a grant exists with different scope'). No code change -- this is
Gitea's own intended behavior. Fix is to revoke UBGitea's existing
authorization from Gitea's Settings > Applications page before retrying
login, so a fresh grant is created under the new scope.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Gitea's PUT/DELETE /user/starred/{owner}/{repo} require write:repository
token scope (verified against Gitea's route registration source), but
this app's OAuthClientConfig only ever requested read-only scopes,
enforced by a hard require() -- every star/unstar attempt was guaranteed
to fail server-side (403), surfaced as the reported red 'failed' star.
Adds write:repository as one narrow, explicit exception to the read-only
invariant (every other write scope, including the pre-existing unused
write:user, is still rejected). Requires one manual re-login on already
logged-in devices before it takes effect, since a refresh token carries
forward the scope it was originally granted under.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
modeSwipeGesture's onDragEnd had its comparison signs backwards relative
to this app's drag-follows-finger convention (already correct in
BranchDetailScreen's HorizontalPager): swiping right moved ALL ->
FAVORITES and swiping left moved FAVORITES -> ALL. Swapped the two
branch conditions so a leftward drag reveals FAVORITES (the right-hand
tab) and a rightward drag reveals ALL (the left-hand tab).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- '히스토리' label -> '커밋' across the branch-detail tab, code-browser
history button, and the one permission-denied sentence that used the
word, matching what that screen actually shows.
- SourceContentClassifier now tries EUC-KR (strictly, same discipline as
its existing UTF-8 attempt) before giving up, so legacy Korean-encoded
.cpp/.h source files render instead of failing as UnsupportedEncoding.
A byte sequence invalid in both charsets still correctly falls through.
- OkHttpTransport's default client is now one shared, longer-timeout
OkHttpClient (15s/30s/15s) instead of a fresh unconfigured OkHttpClient()
per call site -- fixes a large commit history/directory listing on this
app's home-NAS-hosted Gitea being misreported as offline purely because
it took longer than the previous 10s default to answer, and lets calls
to the same host reuse one connection pool instead of ~8 separate ones.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Replaces Compose Material3's unthemed default (purple) with a real color
scheme built from Gitea's own brand green, verified against Gitea's source
(--color-logo: #609926). Fixes a live-reported bug where pagination footer
button heights visibly varied by pinning one explicit height on every
button across all four screens' footers, and by sharing one
SimplePaginationFooter for the plain previous/next case. Each repository
row now shows its Gitea-reported primary language and a tappable star
toggle wired to the existing toggleFavorite action.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The app captured Gitea's OAuth refresh token on login but never used it --
an expired access token forced a full new browser-based login (and consent
screen) every time. Now silently exchanges the stored refresh token for a
new access token in the background, proactively before it goes stale,
shared via one AuthSession singleton across all five features' API clients
instead of each independently reading a possibly-stale token.
Verified Gitea's refresh_token grant shape against its own source
(routers/web/auth/oauth2_provider.go) before implementing.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Opening a .pdf file (detected by %PDF- magic bytes) now renders its pages via
Android's built-in PdfRenderer -- no new dependency -- with the same
swipe-between-pages, pinch-zoom, pan, and double-tap-to-toggle-zoom
interaction as the image viewer. The shared gesture logic was extracted into
a ZoomableSwipeableBox composable so it's genuinely reused, not duplicated.
maxInputBytes raised 1MB -> 10MB so real-world photos and PDFs aren't
rejected as Oversized before ever being classified.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Pinch-zoom (1x-5x), pan while zoomed, and double-tap to toggle zoom, added
to the image viewer. Combined with the existing swipe-navigate gesture in
one hand-rolled awaitEachGesture loop that branches on live pointer count,
rather than stacking a second competing pointerInput detector -- avoiding
the same class of tab-swipe/content-scroll gesture conflict TASK-025 hit
twice.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TASK-027: opening an image (PNG/JPEG/GIF/BMP/WebP, detected by magic bytes)
now decodes and shows it, with swipe navigation to the previous/next image
in the same folder; opening a .csv file shows a scrollable table instead of
raw text. Both reuse the tab-swipe/content-scroll gesture-conflict fix so
neither ever triggers the Files/History tab to change underneath it.
TASK-028: the Issues/PR list shows up to 5 numbered page buttons plus a
[ page / total ] jump field, backed by Gitea's X-Total-Count header
(verified against Gitea's own source) and a server-side type=issues filter
so the count excludes pull requests. Every other paginated list is
unchanged, per this session's earlier scoping decision.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The Files/History HorizontalPager and the diff view's own horizontal code
scroll were both trying to consume the same drag, causing jittery scrolling
and text intermittently scrolling out of view. Disable the pager's own
swipe gesture whenever the current tab is showing scrollable source text,
re-enable it everywhere else. Root cause diagnosed live by the human
product owner from watching the behavior directly.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The manually-driven scroll offset from the previous jitter fix had the delta
sign backwards: dragging left revealed the start of the line instead of
further content, opposite of every other horizontally-scrollable surface on
Android. Verified and fixed via scripted adb swipes + screenshots.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Login previously left the app entirely for a separate browser task. Now uses
androidx.browser Custom Tabs, which overlays the app's own activity instead of
switching away, and returns automatically on redirect. Deliberately not a
WebView, per RFC 8252: an in-app WebView could read the Gitea login form's
credentials directly.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sharing one ScrollState across every row in the diff panels made each row's
layout pass overwrite the shared max-scroll bound with its own line width,
so the visible offset snapped back and forth mid-drag ("글자가 춤을 추네").
Replace it with a manually-driven offset clamped against one bound computed
once per file, instead of recomputed per row.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- Branch/tag tap opens one screen with swipeable Files/History tabs (Route.BranchDetail replaces Route.CodeBrowser/Route.History)
- Repository rows show last-commit time; repository All/Favorites tabs are swipeable
- Fix overlapping commit-detail layout (BoxWithConstraints sibling stacking)
- Fix BranchDetailScreen tab row jammed against status bar
- Fix diff view horizontal scroll not working
- Simplify references-loading message; remove in-app back buttons in favor of system back gesture; replace manual refresh buttons with pull-to-refresh
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Live, iterative round of changes driven by the human product owner
testing on their own device over wireless adb:
- Tapping a branch/tag opens commit history instead of the file browser
- Selected reference row is color-coded instead of a text label
- Branch/tag rows and commit rows show commit date/time with time zone
- Tapping a changed file shows a parsed before/after diff, client-side
(new UnifiedDiffParser, no extra network call)
- The two diff panels scroll vertically in sync and share one
horizontal scroll position
- Diff lines are colored by text only (red/green)
- On a >=600dp-wide screen (a Z Fold's inner screen unfolded) the file
list and selected diff show side by side
- Removed the branch/tag compare feature entirely, per direct request
Also fixes a real bug found via live device debugging: getCommitDetail
requested the wrong URL path (missing "git/"), causing every commit
tap to 404.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Gitea's Go handlers serialize a nil slice as the JSON literal `null`
rather than `[]` for some list endpoints when there are no items
(e.g. a repository with no branches). parseList treated that as a
parse failure and threw ApiFailure.InvalidResponse, surfacing as a
misleading "server error" on a completely successful 200 OK.
Diagnosed live against the human product owner's real Gitea instance
via wireless adb (repositories CSOT-T8-iPTN-AMA / CSOT-T8-MACRO_SA):
confirmed via the Gitea container's own request log that the call
was a genuine 200 OK, then used temporary debug-only logging to
narrow the cause to the literal null body. Fixed at the shared
parseList helper so every sibling list endpoint benefits, not just
the one that was reported.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Continues Codex's paused in-progress fix in this worktree (confirmed
safe to pick up by the human product owner). A missing or malformed
branch commit timestamp no longer fails the whole branch page; the
latest-branch picker now filters to branches with a known timestamp
before selecting the max, and reports Failed (not Empty) when none
are known. Adds the one missing test case from the in-progress
coverage (all branches with unknown timestamps) plus an explicit
test proving the reference screen never depended on the field.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Fixes the recorded P3 CodeBrowserViewModel Main-dispatcher issue,
scans the whole repo for secrets, and reviews the manifest/backup/
token-storage security posture. Minification and any authenticated-
screen device regression are explicitly left blocked: this agent
cannot enter a password to complete Gitea login, confirmed with the
human product owner rather than silently skipped.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-in users can view notifications (unread-only or all), paginated,
and jump from an issue/PR notification to that repository's work items.
No mark-read/unread/pinned write endpoint is exposed, matching the
existing single-write-scope posture from ADR-004.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds read-only GET /user/orgs and GET /orgs/{org}/repos to
GiteaRepositoryBrowserApi (a third interface, OrganizationsRepository),
reusing existing repository mapping rather than duplicating it.
Repository list gains an organization filter chip row (all + one per
org), keeping the existing recent-push sort and paging. Organizations
are fetched once per session and cached; a failure to load them
degrades to an empty filter row instead of blocking the repository
list itself. Filtering only applies to the all-repositories mode,
since Gitea star is not organization-scoped.
Closes MVP outcome #2 in docs/product.md. No task file existed
beforehand; created it first per AGENTS.md.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Replace MainActivity's three independent booleans (browsingCode/
browsingHistory/browsingWorkItems) with one typed List<Route> back
stack, restorable through configuration change and process death.
Route holds only stable primitives (owner/name/ref/ref-kind), never
tokens or content. A genuine LIFO stack, not just a refactor: back now
correctly unwinds through arbitrarily nested screens instead of
relying on which boolean happened to still be true underneath another.
No task file existed for this task beforehand (only proposed in an
earlier handoff document); created it first per AGENTS.md.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Separate issue and PR list/detail tabs, paginated, with comments
(issues) and reviews+comments (PRs). Deleted/unavailable authors
render a fixed placeholder instead of crashing or inventing identity;
every status is a text label, never color-only.
Reuses TASK-010 directly; no shared/domain file touched. Both list
types dedupe by number per page. Entry point is a new button on the
repository references screen.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Paginated commit history for the current ref, commit detail with
distinguished added/modified/deleted/renamed file status, bounded and
explicitly-truncated patch text, and a ref comparison flow validating
one entered ref against the currently open ref as base.
Reuses TASK-004's listCommits and this session's own TASK-009
HistoryRepository; no shared/domain file touched. Entry point is a new
history button on the existing code browser header.
Self-review caught and fixed a bug before writing tests: a failed
commit-detail fetch discarded which commit had failed, so retry
silently reloaded the whole list instead of re-fetching the commit the
user tried to open.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Implemented directly at human product owner's direction, independent
of Codex's separate uncommitted attempt at the same task (not read or
referenced here).
- CommitDetail (reusing CommitSummary) with per-file added/modified/
deleted/renamed/other status; deleted-author and missing-rename-path
cases handled without crashing or inventing data.
- BoundedPatch for commit and comparison diffs, sourced from Gitea's
.diff raw-text endpoints (JSON commit/compare objects only carry
file status, not diff content); byte limit then line limit, both
constructor-injected and validated positive.
- Comparison uses one combined base...head path segment, built by
concatenating both refs before a single addPathSegment call so each
is escaped exactly once; pagination computed locally since Gitea's
compare endpoint has no server-side paging.
- Reuses Page<T> and ApiFailure; no put/delete/postForm call anywhere
in the file (read-only, as required).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Frozen domain/data contracts for issues, pull requests, reviews, and
comments so TASK-008's UI can be built without touching shared layers.
- Separate immutable IssueSummary/Detail and PullRequestSummary/Detail
models; WorkItemAuthor.Unavailable instead of inventing an identity
for deleted/null authors.
- PullRequestState derived from Gitea's merged flag + open/closed
state (no single field already encodes "merged").
- listIssues drops entries with a non-null pull_request field so
Gitea's issue-list endpoint (which also returns PRs) never
duplicates listPullRequests, done client-side rather than trusting
an unverified query parameter.
- Reuses existing Page<T> and ApiFailure rather than new parallel
types. Read-only: no put/delete/postForm call anywhere in the file.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TASK-018, human product owner priority-1 request. Adds write:user
OAuth scope (ADR-004) and relaxes OAuthClientConfig's read-only guard
to an explicit, hard-coded write-scope allow-list rather than a
general write-scope allowance. GiteaRepositoryBrowserApi gains star/
unstar/listStarred via a new RepositoryFavorites interface, reusing
its existing repository mapping. RepositoryListViewModel tracks an
ALL/FAVORITES mode; toggling favorite confirms against the server
before updating UI state rather than acting optimistically.
No create/edit/merge/close/comment endpoint is introduced. Favorite
state is never cached locally.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TASK-017, human product owner priority-1 request. Repository list now
requests sort=updated&order=desc from Gitea, loads 5 repositories per
page with explicit prev/next navigation, and each visible row
independently fetches and shows its most recently committed branch.
Removes the legacy eager-loading RepositoryListApi in favor of the
existing paged GiteaRepositoryBrowser.listRepositories. Fixes two
issues found in self-review: missing error handling on page
navigation, and repositories with no default branch (empty repos)
previously failing the whole page instead of just that row.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Independent read-only review of 8a47d30/bbbff77/16c46a5 per
handoff/claude-master-handoff.md's review-and-freeze step. Verified
build/test/lint independently rather than trusting recorded evidence.
Fixed P2: requireSuccess() collapsed HTTP 409/422 into the generic
InvalidResponse, which would have blocked TASK-007's planned
conflict/unprocessable error states. Added ApiFailure.Conflict and
ApiFailure.Unprocessable with test coverage.
Recorded a P3 (CPU-bound work on the Main dispatcher in
CodeBrowserViewModel) for TASK-016 rather than fixing it now. Closed
TASK-005/006's mutual contract-freeze checkboxes. No P0/P1 found.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Pure-Kotlin classifier for feature/codebrowser/content/ that turns
already-loaded SourceContent bytes into bounded text, binary, Git LFS
pointer, unsupported-encoding, or oversized results with caller-supplied
positive byte/character/line limits, per handoff/task-006a-ready.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
