diff --git a/docs/development-log.md b/docs/development-log.md index 46919be..d999fda 100644 --- a/docs/development-log.md +++ b/docs/development-log.md @@ -731,3 +731,21 @@ This is the append-only implementation and handoff record shared by Codex and Cl dark-mode check to the remaining screens; separately, consider a small follow-up task to surface repository/branch context in the work-items and code-browser headers. - Next owner: Claude, continuing per the standing direction. + +## 2026-08-29 (continued) — TASK-039 follow-up: extended design review, no further changes needed + +- Agent and role: Claude, direct continuation of the same live session, continuing the design-review + pass per the standing direction after committing TASK-039's first batch of fixes. +- What was reviewed: the code browser's file tree (폴더/파일 rows, breadcrumb), the commit history + list, and the per-file diff view (tapping into an individual file's change from a commit) — both in + light and dark mode (`adb shell cmd uimode night yes`/`no`). +- Outcome: no code changes needed. The per-file diff view already does proper git-style red/green + color-coding (`DiffAddedColor` for additions, `MaterialTheme.colorScheme.error` for removals) in a + side-by-side 기존(before)/변경(after) layout with a monospace font, and it holds up cleanly in dark + mode too. The file tree and commit list are visually consistent with the rest of the app's list-row + pattern (title + metadata, no icon library, matching the app-wide convention). +- Files changed: `tasks/039-design-pass-app-icon-and-visual-polish.md`'s Evidence/Known limitations + sections updated to record this review pass; no source changes. +- Next recommended task: continue into work-item/PR detail views with real content and the text/image/CSV/PDF + file viewers, and extend the dark-mode pass to notifications/settings/work-items. +- Next owner: Claude, continuing per the standing direction. diff --git a/tasks/039-design-pass-app-icon-and-visual-polish.md b/tasks/039-design-pass-app-icon-and-visual-polish.md index d722df4..ec8185f 100644 --- a/tasks/039-design-pass-app-icon-and-visual-polish.md +++ b/tasks/039-design-pass-app-icon-and-visual-polish.md @@ -109,19 +109,24 @@ notifications, settings) in both light and dark mode: - PR label: screenshot-confirmed on the notifications "전체" tab against real data (a repository with an actual PR/issue history) — every row now reads "PR" inline with "이슈"/"열림"/"닫힘"/"병합됨" on one line instead of wrapping "Pull" and "Request" onto two. - - Dark mode: forced via `adb shell cmd uimode night yes`, screenshot-reviewed the repository list - and references screens, restored to `night no` afterward — no contrast or legibility issues found. + - Dark mode: forced via `adb shell cmd uimode night yes`, screenshot-reviewed the repository list, + references, code-browser file tree, commit history list, and the colorized per-file diff view, + restored to `night no` afterward — no contrast or legibility issues found anywhere reviewed. + - Also reviewed without code changes (already well-designed, nothing to fix): the code-browser file + tree (폴더/파일 rows, breadcrumb), the commit history list, and the per-file diff view — which + already does proper red/green (`DiffAddedColor`/`colorScheme.error`) side-by-side 기존/변경 + columns in monospace, in both light and dark mode. ## Known limitations - Work-items and code-browser screens still don't show which repository/branch they belong to in their own header — noticed during this review but scoped out (see Scope) since it needs new state threaded through the ViewModel/use-case layer, not a view-only change. -- Dark-mode review in this pass covered the repository list and references screens only, not work - items/notifications/settings/code-browser — those still need a dark-mode pass. -- The rest of the screen-by-screen review (code browser file tree and viewers, commit history/diff, - work-item and PR detail views with real content) has not yet happened — this task covers the first - batch of concrete fixes found so far, not a complete pass. +- Dark-mode review now also covers the code browser and commit/diff screens (see Evidence above), but + not yet notifications/settings/work-items — those still need a dark-mode pass. +- Work-item and PR detail views with real content, and the text/image/CSV/PDF file viewers, haven't + been screen-reviewed yet — this task covers the batch of concrete fixes found so far, not a fully + complete pass. ## Review findings